make modifiers spec compliant #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencroker
approved these changes
Dec 10, 2024
bencroker
added a commit
that referenced
this pull request
Dec 10, 2024
* scratch no longer has a /tmp dir, move to alpine we need all the files cause Docker COPY doesn't support glob * Update routes_home.templ (#319) Remove two typos * toggleAll & setAll use path instead of regex (#318) * toggleAll & setAll use path instead of regex Fixes #317 * Fix wording --------- Co-authored-by: Ben Croker <[email protected]> * Update release note * Update go_deeper.md (#320) Minor edits to Signals section, for grammar, clarity * Make retries and backoff configurable (#316) Fixes #190 * Fix links to SDKs * Tweak intro code * Improve getting started guide * Fix and improve getting started guide * Add web components * evt.detail.value not working for third party libs (#326) * evt.detail.value not working for third party libs Fixes #324 * regex is never fun * fix possible xss on errors * Add circular logo * fix clipboard usage on front page * Support closing SSE connection from client side (#327) Fixes #276 * Fix link in readme * refactor: `nodejs`, `npm`, and `pnpm` are needed for the `libpub` task * data-ref bug (#333) * data-ref bug Fixes #331 * Merge branch 'develop' of github.com:starfederation/datastar into delaneyj/issue331 * adds context.WithTimeout to site smoketests (#334) removes got lib refs * Java SDK (#321) * Examples * SDK and Readme * Added build files * Fixed Readme * add SDKs to frontpage * TODONE: BEN! * Importing Datastar (#335) Fixes #329 * bad link * Rename default constant (#330) * Rename default constant * Fix PHP usage * Build * Remove Teleport from docs * Bundler bug (#347) Fixes #339 * make modifiers spec compliant (#346) * make modifiers spec compliant Fixes #345 * `_` for modifier args is now back to `.`. Please let it end * remove unused error * bump version * Release notes and VSCode release * Update VSCode version number * Fix up modifier docs --------- Co-authored-by: Wm Talcott <[email protected]> Co-authored-by: Ben Croker <[email protected]> Co-authored-by: Ben Croker <[email protected]> Co-authored-by: Andrew Welch <[email protected]> Co-authored-by: zangster300 <[email protected]> Co-authored-by: Peter Humulock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345
Because we use
_for local vs remote signals we have too many overloads. Data-* attributes are very limited in valid names that don't resort to special hard to type characters...__seems to be the only valid option currently